add networkVersion error

MetaMask · Mar 12, 2024 · 10ee3a3 · 10ee3a3
1 parent 85335f4
commit 10ee3a3
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 3 deletions.
diff --git a/jest.config.js b/jest.config.js
@@ -46,9 +46,9 @@ const baseConfig = {
   coverageThreshold: {
     global: {
       branches: 61.45,
-      functions: 63.15,
-      lines: 63.41,
-      statements: 63.48,
+      functions: 63.91,
+      lines: 63.59,
+      statements: 63.65,
     },
   },
 

diff --git a/src/MetaMaskInpageProvider.test.ts b/src/MetaMaskInpageProvider.test.ts
@@ -999,6 +999,20 @@ describe('MetaMaskInpageProvider: Miscellanea', () => {
     });
   });
 
+  describe('networkVersion', () => {
+    let provider: any | MetaMaskInpageProvider;
+
+    beforeEach(async () => {
+      provider = (await getInitializedProvider()).provider;
+    });
+
+    it('should throw an error when accessing networkVersion', () => {
+      expect(() => provider.networkVersion).toThrow(
+        `'ethereum.networkVersion' has been removed`,
+      );
+    });
+  });
+
   describe('selectedAddress', () => {
     let provider: any | MetaMaskInpageProvider;
 

diff --git a/src/MetaMaskInpageProvider.ts b/src/MetaMaskInpageProvider.ts
@@ -157,6 +157,10 @@ export class MetaMaskInpageProvider extends AbstractStreamProvider {
     throw new Error(messages.errors.invalidPropertyChainId());
   }
 
+  get networkVersion(): string | null {
+    throw new Error(messages.errors.invalidPropertyNetworkVersion());
+  }
+
   get selectedAddress(): string | null {
     throw new Error(messages.errors.invalidPropertySelectedAddress());
   }

diff --git a/src/messages.ts b/src/messages.ts
@@ -18,6 +18,8 @@ const messages = {
       `'args.logger' must include required method '${method}'.`,
     invalidPropertyChainId: () =>
       `MetaMask: 'ethereum.chainId' has been removed. Please use the 'eth_chainId' RPC method instead.\nFor more information, see: https://github.com/MetaMask/metamask-improvement-proposals/discussions/23`,
+    invalidPropertyNetworkVersion: () =>
+      `MetaMask: 'ethereum.networkVersion' has been removed. Please use the 'net_version' RPC method instead.\nFor more information, see: https://github.com/MetaMask/metamask-improvement-proposals/discussions/23`,
     invalidPropertySelectedAddress: () =>
       `MetaMask: 'ethereum.selectedAddress' has been removed. Please use the 'eth_accounts' RPC method instead.\nFor more information, see: https://github.com/MetaMask/metamask-improvement-proposals/discussions/23`,
   },