Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @metamask/json-rpc-engine and @metamask/rpc-errors #253

Merged
merged 5 commits into from
Sep 5, 2023
Merged

Use @metamask/json-rpc-engine and @metamask/rpc-errors #253

merged 5 commits into from
Sep 5, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Apr 19, 2023 •
edited by legobeat
Loading

No description provided.

@socket-security
Copy link

socket-security bot commented Apr 19, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@socket-security
Copy link

socket-security bot commented Jul 14, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/rpc-errors 6.0.0 None +0 91.8 kB metamaskbot

🚮 Removed packages: [email protected], [email protected]

This was referenced Aug 24, 2023
Closed
Merged
Closed
@legobeat
Copy link
Contributor

legobeat commented Sep 1, 2023

@FrederikBolding #277

@legobeat legobeat mentioned this pull request Sep 2, 2023
Merged
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Sep 2, 2023
legobeat
legobeat previously approved these changes Sep 2, 2023
View reviewed changes
@legobeat legobeat marked this pull request as ready for review September 2, 2023 06:52
@legobeat legobeat requested a review from a team as a code owner September 2, 2023 06:52
@legobeat
Copy link
Contributor

legobeat commented Sep 2, 2023 •
edited
Loading

The restriction in exported type makes this a breaking change. Therefore:

Blocked by

Blocks

This was referenced Sep 2, 2023
Merged
Merged
Merged
@legobeat legobeat requested review from Mrtenz and a team September 4, 2023 07:45
FrederikBolding and others added 5 commits September 4, 2023 17:56
@FrederikBolding @legobeat
Use metamask/json-rpc-engine and metamask/rpc-errors
9b4fcae
@FrederikBolding @legobeat
Fix imports
29f119f
@FrederikBolding @legobeat
Fix lint
25014a0
@legobeat
Fix: Use @metamask/json-rpc-engine and @metamask/rpc-errors (#277)
8ffc354 
* deps: @metamask/rpc-errors@^5.1.1->^6.0.0
* deps:@metamask/utils@^6.2.0->^7.1.0
* update @metamask/utils v7 usage
* deps: @metamask/json-rpc-engine@^7.0.0->^7.1.1
* test: type fixes
@legobeat
deps: @noble/[email protected]>1.3.2
5543db6
@legobeat legobeat requested review from a team and leotm September 4, 2023 09:22
@legobeat legobeat merged commit 080979d into main Sep 5, 2023
16 checks passed
@legobeat legobeat deleted the fb/bump-json-rpc-engine branch September 5, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

@legobeat legobeat legobeat approved these changes

@leotm leotm Awaiting requested review from leotm

@sethkfman sethkfman Awaiting requested review from sethkfman

@OGPoyraz OGPoyraz Awaiting requested review from OGPoyraz

@naugtur naugtur Awaiting requested review from naugtur

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrederikBolding @legobeat @Mrtenz