-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update to streams3 API #288
Conversation
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @types/[email protected] |
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
d594081
to
c5e9dc1
Compare
set subdep readable-stream to ^3.6.2 in resolutions
|
I mean, the tests pass. We probably want to test this locally in extension and see what happens. I imagine it'll just work though |
Tested locally. Seems to work fine |
Changed
[email protected]
.extension-port-stream
from^2.1.1
to^3.0.0
json-rpc-middleware-stream
from^4.2.3
to^5.0.1
@metamask/object-multiplex
from^1.3.0
to^2.0.0
readable-stream@^3.6.2
The package is previously mixing usage of
readable-stream@2
,readable-stream@3
and Node.js native streams (the API and behavior of which differ depending on Node.js version). This consolidates all internal streams on portablereadable-stream
.