Address PR comments

MetaMask · Nov 19, 2024 · 89024f6 · 89024f6
1 parent c77adcd
commit 89024f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/packages/snaps-execution-environments/src/common/endowments/endowments.test.browser.ts b/packages/snaps-execution-environments/src/common/endowments/endowments.test.browser.ts
@@ -227,10 +227,8 @@ describe('endowments', () => {
           new ResponseWrapper(
             new Response(),
             { lastTeardown: 0 },
-            // eslint-disable-next-line @typescript-eslint/no-empty-function
-            async () => {},
-            // eslint-disable-next-line @typescript-eslint/no-empty-function
-            async () => {},
+            async () => undefined,
+            async () => undefined,
           ),
       },
     };

diff --git a/packages/snaps-execution-environments/src/common/endowments/network.ts b/packages/snaps-execution-environments/src/common/endowments/network.ts
@@ -145,8 +145,11 @@ export class ResponseWrapper implements Response {
   }
 }
 
+// We redefine the global Response class to overwrite [Symbol.hasInstance].
+// This fixes problems where the response from `fetch` would not pass
+// instance of checks, leading to failures in WASM bindgen.
 class AlteredResponse extends Response {
-  static [Symbol.hasInstance](instance: any) {
+  static [Symbol.hasInstance](instance: unknown) {
     return instance instanceof Response || instance instanceof ResponseWrapper;
   }
 }