Fix form values

MetaMask · Jun 19, 2024 · c1f38b8 · c1f38b8
1 parent afa01aa
commit c1f38b8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 7 deletions.
diff --git a/packages/snaps-jest/src/internals/simulation/files.ts b/packages/snaps-jest/src/internals/simulation/files.ts
@@ -1,4 +1,3 @@
-import type { FileOptions } from '@metamask/snaps-jest';
 import type { File } from '@metamask/snaps-sdk';
 import { AuxiliaryFileEncoding } from '@metamask/snaps-sdk';
 import type { VirtualFile } from '@metamask/snaps-utils';
@@ -8,6 +7,8 @@ import { readFile } from 'fs/promises';
 import mime from 'mime';
 import { basename, extname, resolve } from 'path';
 
+import type { FileOptions } from '../../types';
+
 /**
  * Get a statically defined Snap file from an array of files.
  *

diff --git a/packages/snaps-jest/src/internals/simulation/interface.test.tsx b/packages/snaps-jest/src/internals/simulation/interface.test.tsx
@@ -307,6 +307,19 @@ describe('getFormValues', () => {
       },
     });
   });
+
+  it('returns null values as null', () => {
+    const state = {
+      foo: null,
+    };
+
+    const result = getFormValues(state);
+
+    expect(result).toStrictEqual({
+      value: { foo: null },
+      files: {},
+    });
+  });
 });
 
 describe('clickElement', () => {

diff --git a/packages/snaps-jest/src/internals/simulation/interface.ts b/packages/snaps-jest/src/internals/simulation/interface.ts
@@ -302,12 +302,10 @@ export function getFormValues(state?: FormState): FormValues {
   return Object.entries(state).reduce<FormValues>(
     (accumulator, [key, value]) => {
       const formValue = value as string | File | null;
-      if (formValue) {
-        if (typeof formValue === 'string') {
-          accumulator.value[key] = formValue;
-        } else {
-          accumulator.files[key] = formValue;
-        }
+      if (typeof formValue === 'string' || formValue === null) {
+        accumulator.value[key] = formValue;
+      } else {
+        accumulator.files[key] = formValue;
       }
 
       return accumulator;