Fix for typescript 5.0 breaking change - forbidden implicit coercions…

… in relational operators
MetaMask · Jul 22, 2024 · fffe4b2 · fffe4b2
1 parent 3178d79
commit fffe4b2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/snaps-simulator/src/features/builder/components/BaseNode.tsx b/packages/snaps-simulator/src/features/builder/components/BaseNode.tsx
@@ -39,7 +39,7 @@ export const BaseNode: FunctionComponent<BaseNodeProps> = ({
       borderColor="border.default"
       display={isDragging ? 'none' : 'flex'}
       marginX="4"
-      cursor={node.id > 1 ? 'move' : 'default'}
+      cursor={Number(node.id) > 1 ? 'move' : 'default'}
     >
       <Icon icon={node.data.type.toLowerCase() as IconName} width="16px" />
       <Text
@@ -53,7 +53,7 @@ export const BaseNode: FunctionComponent<BaseNodeProps> = ({
         {node.data.type}
       </Text>
       {children}
-      {node.id >= 2 && (
+      {Number(node.id) >= 2 && (
         <Icon
           icon="cross"
           width="11px"

diff --git a/packages/snaps-simulator/src/features/builder/components/NodeTree.tsx b/packages/snaps-simulator/src/features/builder/components/NodeTree.tsx
@@ -99,7 +99,7 @@ export const NodeTree: FunctionComponent<NodeTreeProps> = ({
 
   const handleCanDrag = (node?: NodeModel<JSXElement>) => {
     if (node) {
-      return node.id >= 2;
+      return Number(node.id) >= 2;
     }
 
     return false;
@@ -113,7 +113,7 @@ export const NodeTree: FunctionComponent<NodeTreeProps> = ({
       return (
         canDropElement(dropTarget?.data, dragSource?.data) &&
         dropTarget?.droppable &&
-        dropTargetId > 0
+        Number(dropTargetId) > 0
       );
     }