fix: Make ResponseWrapper an instance of Response
#2889
Merged
+84
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2889 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 486 486
Lines 10401 10404 +3
Branches 1595 1596 +1
=======================================
+ Hits 9828 9831 +3
Misses 573 573 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
FrederikBolding
commented
Nov 15, 2024
packages/snaps-execution-environments/src/common/endowments/network.ts
Outdated
Show resolved
Hide resolved
Mrtenz
reviewed
Nov 19, 2024
packages/snaps-execution-environments/src/common/endowments/endowments.test.browser.ts
Outdated
Show resolved
Hide resolved
Mrtenz
reviewed
Nov 19, 2024
Mrtenz
reviewed
Nov 19, 2024
packages/snaps-execution-environments/src/common/endowments/network.ts
Outdated
Show resolved
Hide resolved
Mrtenz
approved these changes
Nov 19, 2024
FrederikBolding
force-pushed
the
fb/reponsewrapper-instanceof-response
branch
from
d2a506a
to
89024f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overwrite
[Symbol.hasInstance]on the exposedResponseclass slightly to makeResponseWrapperpassinstanceofchecks. This preventsfetchresponses from failing when using WASM bindgen for instance.Fixes #2891