Add support for custom dialogs in snaps-jest
#2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2526 +/- ##
==========================================
+ Coverage 93.90% 93.93% +0.03%
==========================================
Files 455 455
Lines 9477 9531 +54
Branches 1447 1458 +11
==========================================
+ Hits 8899 8953 +54
Misses 578 578 ☔ View full report in Codecov by Sentry. |
Mrtenz
requested changes
Jun 28, 2024
Mrtenz
reviewed
Jul 1, 2024
| @@ -141,6 +141,7 @@ describe('onRpcRequest', () => { | |||
| }); | |||
|
|
|||
| const ui = await response.getInterface(); | |||
There was a problem hiding this comment.
Now that I think about it, it seems easier to specify the expected type in getInterface rather than having to assert all the time.
Suggested change
| const ui = await response.getInterface(); | |
| const ui = await response.getInterface('confirmation'); | |
| // `ui` is now `ConfirmationDialog` type |
I can take care of this in a separate PR.
Mrtenz
approved these changes
Jul 1, 2024
GuillaumeRx
force-pushed
the
gr/support-resolvable-interfaces
branch
from
0238f1c
to
665aee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for the new
defaulttype dialog.