fix: Filter out some Struct errors based on key #2533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LwkkyLDdubz
approved these changes
Jul 3, 2024
| @@ -469,7 +469,6 @@ describe('implementation', () => { | |||
| ); | |||
|
|
|||
| it.each([ | |||
| { type: DialogType.Alert }, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| ); | ||
| }); | ||
|
|
||
| it('rejects invalid fields', async () => { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -469,7 +469,6 @@ describe('implementation', () => { | |||
| ); | |||
|
|
|||
| it.each([ | |||
| { type: DialogType.Alert }, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -487,7 +486,22 @@ describe('implementation', () => { | |||
| params: value as any, | |||
| }), | |||
| ).rejects.toThrow( | |||
| /Invalid params: At path: .* — Expected a value of type .*, but received: .*\./u, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters out some Struct errors in
validateUnionby looking at thekey. If thekeyisn't specified in the object we are trying to validate we will assume that that branch of validation errors isn't interesting to the user.This improves error messages for
snap_dialogsomewhat as the error message will correctly mention thatcontentis invalid:Invalid params: At path: content — Expected the value to be one of: object, object, but received: ....This PR does not fix the fact that the error message still doesn't explain what was expected of the union.