Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Release/56.0.0 (#2581)" #2582

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Revert "Release/56.0.0 (#2581)" #2582

merged 1 commit into from
Jul 17, 2024

Conversation

MajorLift
Copy link
Contributor

This reverts commit ffa9dd1.

@MajorLift MajorLift self-assigned this Jul 17, 2024
@MajorLift MajorLift requested a review from a team as a code owner July 17, 2024 21:32
@MajorLift MajorLift mentioned this pull request Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.99%. Comparing base (ffa9dd1) to head (675974f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2582   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files         459      459           
  Lines        9647     9647           
  Branches     1480     1480           
=======================================
  Hits         9068     9068           
  Misses        579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MajorLift MajorLift merged commit 58e84f2 into main Jul 17, 2024
156 checks passed
@MajorLift MajorLift deleted the revert-release-56.0.0 branch July 17, 2024 21:49
MajorLift added a commit that referenced this pull request Jul 17, 2024
Re-do of release commit: #2581
- Blocked by #2582

Previous attempt failed to meet `is-release` action's criteria for
release commits:
- `commit-starts-with: 'Release [version]'`

---------

Co-authored-by: Maarten Zuidhoorn <[email protected]>
MajorLift added a commit that referenced this pull request Jul 17, 2024
@MajorLift MajorLift mentioned this pull request Jul 17, 2024
MajorLift added a commit that referenced this pull request Jul 18, 2024
This is the release candidate for v56.0.0.

The previous release candidate
(#2583) was completely overwritten
by a main branch merge commit
(cb55071),
because the preceding revert commit
(#2582) introduced "newer" changes
than the commits in the release candidate branch. For future reference,
rebasing would be safer in this situation.

As a result, the main branch is currently restored to its original state
prior to the first release attempt
(ffa9dd1), enabling us to move forward
with this PR without having to merge an additional revert commit.

This commit reverts commit 58e84f2,
which restores the contents of the original release candidate for
v56.0.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants