Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and related files to match module template #6

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 1, 2024

No description provided.

Copy link

socket-security bot commented Mar 1, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] None 0 21.9 kB bmealey
npm/[email protected] None 0 976 kB olivernn
npm/[email protected] None 0 428 kB tonybrix
npm/[email protected] filesystem, network +4 16.8 MB antfu
npm/[email protected] Transitive: filesystem, network +9 88.4 MB typedoc-bot
npm/[email protected] network 0 490 kB vscode-bot
npm/[email protected] None 0 347 kB vscode-bot

View full report↗︎

Copy link

socket-security bot commented Mar 1, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Network access npm/[email protected]
New author npm/[email protected]
Network access npm/[email protected]

View full report↗︎

Next steps

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but otherwise looks good.

.github/pull_request_template.md Outdated Show resolved Hide resolved
Base automatically changed from mrtenz/tsup to main March 1, 2024 17:59
@Mrtenz Mrtenz force-pushed the mrtenz/module-template-ci branch from 8f9e15c to 0413a10 Compare March 1, 2024 18:00
@Mrtenz Mrtenz marked this pull request as ready for review March 1, 2024 18:00
@Mrtenz
Copy link
Member Author

Mrtenz commented Mar 1, 2024

auto-changelog is missing, causing CI to fail. Will address that in a future PR.

@Mrtenz Mrtenz requested a review from mcmire March 1, 2024 18:04
Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mrtenz Mrtenz merged commit 590c9c2 into main Mar 1, 2024
9 of 16 checks passed
@Mrtenz Mrtenz deleted the mrtenz/module-template-ci branch March 1, 2024 20:46
@Mrtenz Mrtenz mentioned this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants