Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #7

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix tests #7

merged 1 commit into from
Mar 1, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 1, 2024

I made a few small mistakes in #4, causing the tests to break. This fixes it.

Blocked by #5.

for (const { validate } of Structs) {
const [error, coerced] = validate(value, { coerce: true });
for (const InnerStruct of Structs) {
const [error, coerced] = InnerStruct.validate(value, { coerce: true });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was broken because Struct.validate references this.

Base automatically changed from mrtenz/tsup to main March 1, 2024 17:59
@Mrtenz Mrtenz marked this pull request as ready for review March 1, 2024 20:48
@Mrtenz Mrtenz requested a review from a team as a code owner March 1, 2024 20:48
Copy link

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mrtenz Mrtenz merged commit 734f725 into main Mar 1, 2024
14 of 16 checks passed
@Mrtenz Mrtenz deleted the mrtenz/fix-tests branch March 1, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants