-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies update #223
base: main
Are you sure you want to change the base?
Dependencies update #223
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 🚨 Potential security issues found in this pull request. To accept the risk, merge this PR and you will not be notified again. Bot CommandsTo ignore an alert, reply with a comment starting with
📜 Install scriptsInstall scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.
Pull request alert summary
📊 Modified Dependency Overview:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update .nvmrc
file to v14
as well
@@ -11,7 +11,7 @@ jobs: | |||
runs-on: ubuntu-20.04 | |||
strategy: | |||
matrix: | |||
node-version: [12.x, 14.x, 16.x] | |||
node-version: [14.x, 16.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-version: [14.x, 16.x] | |
node-version: [14.x, 16.x, 18.x] |
Actually, just checked metamask-extension's Might as well upgrade to that one. |
@@ -11,7 +11,7 @@ jobs: | |||
runs-on: ubuntu-20.04 | |||
strategy: | |||
matrix: | |||
node-version: [12.x, 14.x, 16.x] | |||
node-version: [14.x, 16.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're updating the minimum supported Node.js version, we should update the version of Node.js referenced in the README, in package.json
, and in .nvmrc
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aw great catch! I've updated them @Gudahtt thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks in nodejs v18 due to webpack/webpack#14532:
- Proper solution: upgrade to webpack 5. upgrade webpack plugins,
webpack-dev-server
,webpack-cli
- Temporary workaround 1: restrict
engines.node
tov16.x
, disablev18
in ci - Temporary workaround 2: use
NODE_OPTIONS=--openssl-legacy-provider
- As this is intended as a sample dapp, this is something I'd avoid
- Note: I did not get the suggested
output.hashFunction: 'xxhash64'
working (it yields a different error messageDigest not supported
)
I have resolved just the Node.js update in #225 to unblock further publishing |
Due to dependency being broken on 18.x. MetaMask#223 (review)
I just took a new stab at this in #264 |
Context: when installing the npm packages using the Python version
3.11
, the command fails with the error nodejs/node-gyp#2219What: this PR updates the dependencies in order to fix the error.
"@lavamoat/allow-scripts": "^2.0.3",
using the same version frommetamask-extension
yarn allow-scripts auto
The engine "node" is incompatible with this module. Expected version ">=14.0.0". Got "12.22.12"
test-dapp.webm