Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep original type when using hasProperty if defined #94

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 13, 2023

Rather than asserting that the property is unknown, this checks if the object has the property defined, and asserts that type instead.

@Mrtenz Mrtenz requested a review from a team as a code owner March 13, 2023 14:01
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM

@Mrtenz Mrtenz force-pushed the mrtenz/has-property-keep-type branch from 1ad9a0f to a663ae0 Compare April 11, 2023 13:01
@Mrtenz Mrtenz merged commit 3bc97c4 into main Apr 11, 2023
@Mrtenz Mrtenz deleted the mrtenz/has-property-keep-type branch April 11, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants