Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for directory that executable doesn't have permissions for causes crash #659

Closed
tadgerb opened this issue Nov 9, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@tadgerb
Copy link

tadgerb commented Nov 9, 2020

The check for Directory::Exists referenced below doesn't check the paths in the PATH environment variable safely, e.g. if any of the paths exist but cannot be accessed for permissions reasons, the call throws an exception; probably rightly so?; causing the FixProgramSearchPath to crash out. Ideally, it would instead catch those exceptions and carry on, as it doesn't need to include any paths it doesn't have access to.

else if (Directory::Exists(dir) && checkCompetition)

@edocevoli edocevoli self-assigned this Nov 9, 2020
@edocevoli edocevoli added this to the 20.12 milestone Nov 9, 2020
@edocevoli edocevoli added the bug label Nov 9, 2020
@Moving-Electrons
Copy link

When working on this bug, please keep in mind that some of us need to install MiKTeX in portable mode because access to windows system folders is not allowed. Thanks!.

@edocevoli
Copy link
Member

This has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants