-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add branch command (draft) #272
base: master
Are you sure you want to change the base?
Conversation
Implementation looks good so far. As you already put it out a test would be nice and also documentation in the README. |
6fe1fee fixes my caller error
because the branch also there is a bug in rev. when i call
then nix-review fetches the master branch of https://github.com/delroth/nixpkgs but the fork is out-of-sync with NixOS/nixpkgs, so as base commit i get delroth/nixpkgs@045a4a4 (2018-10-13) nix-review should get the |
now this works
this PR still needs some polish ... |
nixpkgs_review/review.py
Outdated
|
||
cache_size_limit = 200 * 1000 * 1000, # 200MB (default: 1GB) | ||
|
||
cache = diskcache.Cache(cache_dir, size_limit = cache_size_limit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have no dependencies outside the python stdlib in nixpkgs-review
. There is for example: https://docs.python.org/3/library/dbm.html and one could just keep the last 100 evals...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eval cache is now a "stupid file cache" with *.xml.gz files (todo: garbage collect)
i think it's useful and stable enough to make eval-cache default on
fix #271
mostly copy-paste of the pr command
pr
command