Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Git root URI should not be absolute for Windows #95

Merged
merged 5 commits into from
Jan 15, 2023
Merged

fix: Git root URI should not be absolute for Windows #95

merged 5 commits into from
Jan 15, 2023

Conversation

MichaelCurrin
Copy link
Owner

Resolves #93

@MichaelCurrin MichaelCurrin mentioned this pull request Jan 12, 2023
Closed
yi-Xu-0100
yi-Xu-0100 reviewed Jan 13, 2023
View reviewed changes
Copy link
Contributor

@yi-Xu-0100 yi-Xu-0100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may fix the path issue in windows.

src/git/cli.ts Outdated Show resolved Hide resolved
@MichaelCurrin
Copy link
Owner Author

oh it's actually fsPath not fspath

@MichaelCurrin MichaelCurrin merged commit 1270cc6 into master Jan 15, 2023
@MichaelCurrin MichaelCurrin deleted the fix-git-root-uri-not-absolute-for-windows branch January 15, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yi-Xu-0100 yi-Xu-0100 yi-Xu-0100 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on Windows - shell cannot spawn
2 participants
@MichaelCurrin @yi-Xu-0100