Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge voxpupuli master #2

Merged
merged 60 commits into from
Apr 15, 2020
Merged

Conversation

MichalRebisz
Copy link
Owner

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

prabiegx and others added 30 commits February 7, 2020 13:32
Instead of having a mix of strings and integers, all port parameters
should be using `Stdlib::Port`.

I've also changed some `String`s to `Stdlib::Host`, but none of these
should be breaking changes.
Added aditional tests for default values

fixed lint error
stahnma-epel has now migrated to VoxPupuli
name space.

Also in particular the `puppet-epel` version is requirment to
work with CentOS 8.
Require puppet-epel over stahnma-epel
The main differences for CentOS 8 are:
* There is now a new collectd-utils package containing collectdctl
* collectd-python is now a seperate sub package
* python is python3.
* pip command is now pip3
* The rabbitmq plugin no longer works due to lack of python3 support

The python_dir fact will fall back to `/usr/libexec/platform-python`
if `python3` does not exist on the path. This is the python
that collectd is built against and significantly requires.

Note that setting `collectd::ci_package_repo` true will currently
result in yum being configured with a non existant repo since
https://pkg.ci.collectd.org/rpm/ does not exist
for 8.

collectd/collectd-ci#35
bastelfreak and others added 29 commits March 10, 2020 23:08
New utils parameter to install collectdctl
As of CentOS 8 the write_http is in its own subpackage
so must be installed on CentOS 8.
write_http/disk is own sub package on CentOS 8
* Addition of CentOS 8 support.
* New utils parameter
The unit tests for python_dir fact were giving a false failure

```
1) python_dir is empty string if python not installed
   Failure/Error: expect(Facter.fact(:python_dir).value).to eq('')
     expected: ""
          got: "/usr/lib/python2.7/site-packages"
     (compared using ==)
```

If they were executed on a system where `/usr/libexec/platform-python`
was present - not the case (presumably) for Travis CI.
Ignore more installed versions of python during tests
Refixes #901

The bug was that a ReportRelative configuration to the load
plugin for collectd 5.9.0 was causing a parse error.
It has been fixed for 5.9.1

collectd module now skips this configuration for collectd for collectd == 5.9.0
Previously it was '!=' 5.9.

* Upsteam bug for collectd: #901
* Previous incorrect commit: 8edc014
Skip Load:ReportRelative as problematic for collectd 5.9.0
There was a name clash between:
* Puppet created configuration file.
* Package provided configuration file which was being purged.

Since a864d0d the collectd module on RedHat
purges the package provided file file `/etc/collectd.d/processes-config.conf`

The module was also creating this file with a concat and result was no
file on system.

To avoid the clash puppet now creates the file `processes_config.conf`. Note
the `-` vs `_`.

There is probably a cleaner fix to move all of the processes plugin configuration
into the per module file `/etc/collect.d/10-processses.conf` as that would
be more consistant with other simpler modules using a single template
rather than a concat. This would be a change for every module
however with `collectd::plugin` itself changing.

Fixes #926
Create processes plugin configuration on RedHat
This PR is a bug fix allowing to install the disk package in versions prior CentOS 8 in case `$manage_package` is configured by the user.
Install disk package if required prior CentOS 8
[collectd] rename log_parser to logparser
Change all `port` parameters to use `Stdlib::Port`
@MichalRebisz MichalRebisz merged commit a431377 into MichalRebisz:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants