Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove magrittr #226

Merged
merged 4 commits into from
Sep 2, 2024
Merged

Remove magrittr #226

merged 4 commits into from
Sep 2, 2024

Conversation

JamesHWade
Copy link
Collaborator

@JamesHWade JamesHWade commented Aug 31, 2024 •
edited
Loading

Related issue

Description of changes

  • Replace %>% with |>
  • Bump min R version from >= 4.0 to >= 4.1
  • Update news
  • Delete revdep folder since we don't have reverse dependencies (yet)

For contributors

  • I have added the relevant changes to the NEWS.md file
  • I have added relevant tests or documentation with my changes
    • existing tests work in this case

For reviewers

  • Changes meet the acceptance criteria of the related issue
  • The contribution follows style conventions and code of conduct
  • Branch passes automated testing
  • I have incremented the package version in the DESCRIPTION file before merging

@JamesHWade JamesHWade marked this pull request as ready for review August 31, 2024 21:27
@calderonsamuel
Copy link
Collaborator

LGTM

@JamesHWade JamesHWade merged commit cd734a3 into main Sep 2, 2024
8 checks passed
@JamesHWade JamesHWade deleted the remove-magrittr branch September 2, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calderonsamuel calderonsamuel calderonsamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR]: Time to migrate from magrittr %>% to base pipe |>?
2 participants
@JamesHWade @calderonsamuel