Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Smart Display sample to 4.7.0 #2726

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Bump Smart Display sample to 4.7.0 #2726

merged 4 commits into from
Dec 13, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Dec 13, 2019 •
edited
Loading

Changelog Entry

Description

Bumping to Web Chat 4.7.0 for one of our highlighted sample for Direct Line Speech.

Specific Changes

  • Bump to Web Chat 4.7.0 in sample 13.b.customization-smart-display
  • Testing Added
    • No tests needed currently, we should write automated tests for every sample

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.121% when pulling e360c01 on compulim:bump-sample-4.7.0-1 into 7811093 on microsoft:master.

corinagum
corinagum approved these changes Dec 13, 2019
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I would just do all of them at once.

@compulim compulim merged commit ada2aff into microsoft:master Dec 13, 2019
@compulim compulim deleted the bump-sample-4.7.0-1 branch December 13, 2019 20:21
@compulim compulim mentioned this pull request Mar 5, 2020
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@tdurnford tdurnford Awaiting requested review from tdurnford tdurnford is a code owner

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@compulim @coveralls @corinagum