Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update timestamp options #1563

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Update timestamp options #1563

merged 2 commits into from
Jan 9, 2019

Conversation

compulim
Copy link
Contributor

@compulim compulim commented Jan 9, 2019

Fix #1562

Changelog

  • playground: Fix #1562. Fixed timestamp grouping "Don't group" and added "Don't show timestamp", by @compulim in PR #1563

@compulim compulim added this to the v4.2.1 (Accessibility red) milestone Jan 9, 2019
@coveralls
Copy link

coveralls commented Jan 9, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 706

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 45.091%
Files with Coverage Reduction New Missed Lines %
packages/component/src/Utils/TimeAgo.js 3 70.59%
packages/component/src/Utils/Timer.js 6 33.33%
Totals Coverage Status
Change from base Build 705: -0.5%
Covered Lines: 730
Relevant Lines: 1450
💛 - Coveralls

@compulim compulim merged commit d9808ca into microsoft:master Jan 9, 2019
@compulim compulim deleted the fix-timestamp-grouping branch January 9, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinagum corinagum corinagum approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.2.1 (Accessibility red)
Development

Successfully merging this pull request may close these issues.
3 participants
@compulim @coveralls @corinagum