Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1602: suggested-action regression #1616

Merged
merged 6 commits into from
Jan 23, 2019
Merged

Fix #1602: suggested-action regression #1616

merged 6 commits into from
Jan 23, 2019

Conversation

corinagum
Copy link
Contributor

Fixes #1602
title was not getting added to postback and imback action buttons.

  • Also added an integration test to prevent this from happening in the future :)

compulim
compulim requested changes Jan 18, 2019
View reviewed changes
packages/component/src/SendBox/SuggestedActions.js Outdated Show resolved Hide resolved
__tests__/suggestedActions.js Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 810

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.6%) to 47.902%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/component/src/SendBox/SuggestedActions.js 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
packages/bundle/src/createDirectLine.js 3 20.0%
Totals Coverage Status
Change from base Build 796: 0.6%
Covered Lines: 798
Relevant Lines: 1503
💛 - Coveralls

@corinagum
Copy link
Contributor Author

ping @compulim @a-b-r-o-w-n, please let me know what you think about the changes :)

a-b-r-o-w-n
a-b-r-o-w-n requested changes Jan 22, 2019
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I found a bug, but otherwise just some style comments.

packages/component/src/SendBox/SuggestedActions.js Show resolved Hide resolved
packages/component/src/SendBox/SuggestedActions.js Outdated Show resolved Hide resolved
packages/component/src/SendBox/SuggestedActions.js Outdated Show resolved Hide resolved
@corinagum
Copy link
Contributor Author

@a-b-r-o-w-n @compulim ping :)

compulim
compulim approved these changes Jan 23, 2019
View reviewed changes
packages/component/src/SendBox/SuggestedActions.js Outdated Show resolved Hide resolved
packages/component/src/SendBox/SuggestedActions.js Outdated Show resolved Hide resolved
@corinagum corinagum merged commit 337922d into microsoft:master Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n requested changes

@compulim compulim compulim approved these changes

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corinagum @coveralls @compulim @a-b-r-o-w-n