Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quotation marks around suggested action #1602

Closed
FRANZKAFKA13 opened this issue Jan 17, 2019 · 1 comment
Closed

Quotation marks around suggested action #1602

FRANZKAFKA13 opened this issue Jan 17, 2019 · 1 comment
Assignees
@corinagum
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner

Comments

@FRANZKAFKA13
Copy link

Hey,

when using the "master" branch, the suggested actions are suddenly surrounded by quotation marks. The functionality is the same, it's just a style issue.

image
@corinagum corinagum self-assigned this Jan 17, 2019
@corinagum corinagum added bug Indicates an unexpected problem or an unintended behavior. front-burner Pending labels Jan 17, 2019
@corinagum
Copy link
Contributor

Hi @FRANZKAFKA13, looks like you might have found a bug, thanks for the catch. Let me get back to you.

@corinagum corinagum mentioned this issue Jan 18, 2019
Merged
@corinagum corinagum removed the Pending label Jan 18, 2019
corinagum pushed a commit that referenced this issue Jan 23, 2019
Fix #1602: suggested-action regression (#1616)
337922d 
* Fix suggested-action regression where title does not get added to postback and imback action buttons

* Fix suggested action regression - title was not being added to postback and imback buttons

* PR fixes, factor out renderer into function

* PR fixes

* Apply spacing suggestions from code review
@corinagum corinagum mentioned this issue Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corinagum @FRANZKAFKA13