Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass 'pollingInterval' to DirectLineJS constructor #1655

Merged
merged 7 commits into from Jan 29, 2019
Merged

pass 'pollingInterval' to DirectLineJS constructor #1655

merged 7 commits into from Jan 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 29, 2019

Fix for issue #1652

Added conversationId as an argument while instantiating DirectLine. Doing this will resume the conversation history related to a particular conversationId
@coveralls
Copy link

coveralls commented Jan 29, 2019

Pull Request Test Coverage Report for Build 885

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.495%

Totals Coverage Status
Change from base Build 879: 0.0%
Covered Lines: 879
Relevant Lines: 1522

💛 - Coveralls

@corinagum
Copy link
Contributor

Rerunning the build - looks like there was a timeout error and I didn't see any discrepancies in the .png archive.

Copy link
Contributor

@compulim compulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants