Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add watermark and streamUrl parameters to DLJS constructor #1817

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Add watermark and streamUrl parameters to DLJS constructor #1817

merged 2 commits into from
Mar 15, 2019

Conversation

corinagum
Copy link
Contributor

@corinagum corinagum commented Mar 15, 2019 •
edited
Loading

Fix #1800, similar to #1655

@corinagum corinagum mentioned this pull request Mar 15, 2019
Closed
@coveralls
Copy link

coveralls commented Mar 15, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 53.637% when pulling 093fdf3 on corinagum:corinagum/DLJSConstructor into 9c217f2 on Microsoft:master.

@corinagum corinagum merged commit caffee2 into microsoft:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyanziano tonyanziano tonyanziano approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@compulim compulim Awaiting requested review from compulim compulim is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@justinwilaby justinwilaby Awaiting requested review from justinwilaby

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corinagum @coveralls @tonyanziano