Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When work with Sogou pinyin Chinese input method, the inputed Chinese word will repeat. #10937

Closed
Ruikuan opened this issue Aug 25, 2016 · 9 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@Ruikuan
Copy link

Ruikuan commented Aug 25, 2016

  • VSCode Version: Code - Insiders 1.5.0-insider (2f2d650, 2016-08-25T06:09:29.461Z)
  • OS Version: Windows_NT ia32 10.0.14393

Steps to Reproduce:

  1. Download Sogou pinyin Chinese input method. It's a very popular Chinese input method, almost top 1, so I think maybe this issue will puzzle many people.
    download
  2. Install the input method, then use it to input any Chinese word, you can see the word will be repeated in the Editor.
    inputing
    inputed
@fantacytyx
Copy link

fantacytyx commented Aug 25, 2016

QQ pinyin have the same problem.

I think the problem is caused by the space
image
animation

@alexdima
Copy link
Member

@Ruikuan @fantacytyx Can you please try today's insiders version, where we made a fix in this area for mac dead key handling (input was doubled), I believe that fix might fix this issue too.

image

@alexdima alexdima added this to the August 2016 milestone Aug 26, 2016
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Aug 26, 2016
@alexdima
Copy link
Member

The relevant commit is 26f5824

@fantacytyx
Copy link

fantacytyx commented Aug 26, 2016

@alexandrudima This issue has been fixed. But I find a new problem that the chars of the input is difficult to undo by using keyboard Ctrl+z.

@alexdima
Copy link
Member

@fantacytyx Thank you for confirming. Indeed, let's track the undo problem in #9675

@Ruikuan
Copy link
Author

Ruikuan commented Aug 26, 2016

@alexandrudima, Issue fixed. Thank you.

@alexdima
Copy link
Member

alexdima commented Aug 29, 2016

@Ruikuan @fantacytyx I have started some time ago a Wiki page where we collect different manual tests for different input methods. Please notice how the tests are written "for dummies" with all the needed steps spelled out.

https://github.com/Microsoft/vscode/wiki/IME-Test

Is it possible that maybe you comment in here such a test for the Sogou pinyin Chinese input method. I can then take it from here and add it to the wiki, such that in the future when we make changes in this area we can also test this input method? [There is already a test for Microsoft Pinyin, maybe we can add one for Sogou too, it looks like they behave differently at the OS level)

@Ruikuan
Copy link
Author

Ruikuan commented Aug 30, 2016

  • Add the Sogou pinyin Chinese input method
    • Download Sogou pinyin Chinese input method from this link
      download link
    • Install Sogou pinyin Chinese input method
      • Double click downloaded install exe
        install exe
      • Click YES if UAC dialog show
        accept uac
      • Click Install immediately in the install UI
        install immediately
      • Wait for the process complete, UNCHECK the "install the Sogou browser"
        uncheck sogou browser
      • Uncheck all options, click finish
        uncheck all options
      • Sogou pinyin Chinese input method install successfully
  • Focus VS Code and switch OS input method to Chinese and choose Chinese mode and make sure the input method's name is Sogou Pinyin:
    sogou pinyin
  • Type ni press Space and then hao and press Space. They should be typed in immediately. Here is how Word looks like doing this:
    input to word
  • Type nihao press Space. It should result into 你好

Hope this can be helpful.

@alexdima
Copy link
Member

@Ruikuan Thank you very much! ❤️ I have added this as a test to the wiki!

https://github.com/Microsoft/vscode/wiki/IME-Test#windows-sogou-pinyin-chinese-input-method

@rebornix rebornix added the verified Verification succeeded label Aug 31, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants