fix dead-key issue on macOS

microsoft · Aug 25, 2016 · 26f5824 · 26f5824
1 parent 61dd51a
commit 26f5824
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/vs/editor/common/controller/textAreaHandler.ts b/src/vs/editor/common/controller/textAreaHandler.ts
@@ -159,7 +159,12 @@ export class TextAreaHandler extends Disposable {
 
 			// Due to isEdgeOrIE (where the textarea was not cleared initially)
 			// we cannot assume the text at the end consists only of the composited text
-			this.textAreaState = this.textAreaState.fromTextArea(this.textArea);
+			if (Browser.isEdgeOrIE) {
+				// In Chrome v49, the text at the time of the compositionend event is not really the final text
+				// for the mac dead key input method.
+				// N.B: This can be removed in Chrome v53
+				this.textAreaState = this.textAreaState.fromTextArea(this.textArea);
+			}
 
 			this.lastCompositionEndTime = (new Date()).getTime();
 			if (!this.textareaIsShownAtCursor) {