Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useAtlasEngine Default Wrong? #721

Closed
ThomasMConnors opened this issue Oct 8, 2023 · 2 comments
Closed

useAtlasEngine Default Wrong? #721

ThomasMConnors opened this issue Oct 8, 2023 · 2 comments

Comments

@ThomasMConnors
Copy link

"experimental.useAtlasEngine" is listed with a default of FALSE.

However, the current JSON Schema shows the default to be true:

    "useAtlasEngine": {
      "description": "Windows Terminal 1.16 and later ship with a new, performant text renderer. Set this to false to revert back to the old text renderer.",
      "type": "boolean",
      "default": true

Document Details

Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

@DHowett
Copy link
Contributor

DHowett commented Oct 8, 2023

Thanks for the report! As with much of our schema stuff, this one is ... not the greatest.

In preview builds, Atlas defaults to true. In stable builds, it defaults to false.

Up until recently, we didn't have a way to point the different versions of Terminal at different versions of the schema (whoops!)
Because of that, we just shipped it with the "average" default values for whatever was in the preview channel for a given Terminal version.

@zadjii-msft
Copy link
Contributor

Furthermore, in microsoft/terminal#16277, we'll be making atlas the default for both stable and preview branches (starting with 1.19 Stable).

(We can't really x-link this issue and that PR across repos, but this will be officially closed by that PR)

@zadjii-msft zadjii-msft closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants