Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable AtlasEngine by default #16277

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Enable AtlasEngine by default #16277

merged 4 commits into from
Dec 4, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Nov 7, 2023

This enables AtlasEngine by default in the 1.19 release branch.
A future change will remove the alternative DxEngine entirely.

@lhecker lhecker added this to the Terminal v1.19 milestone Nov 7, 2023
@@ -90,7 +90,7 @@ Author(s):
X(hstring, TabTitle, "tabTitle") \
X(Model::BellStyle, BellStyle, "bellStyle", BellStyle::Audible) \
X(IEnvironmentVariableMap, EnvironmentVariables, "environment", nullptr) \
X(bool, UseAtlasEngine, "useAtlasEngine", Feature_AtlasEngine::IsEnabled()) \
X(bool, UseAtlasEngine, "useAtlasEngine", true) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this period we'll want to change the name of the setting, so that people who opted out when it was broken get another chance to test it out. I was wondering if we should do that during Preview, though... 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh... We could check the AtlasEngine_Usage metric to see how many users opted out. This would tell us both, how many people this switch might (negatively) surprise and also whether introducing a new name for this setting is useful in the first place. Should we do that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might (negatively) surprise

To be fair, #16278 isn't going to do those people any favors 😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to regain access to Kusto to tell you about Atlas usage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair, #16278 isn't going to do those people any favors 😆

That's true, but it targets the 1.20 branch, so if there's anything in AtlasEngine that upsets an unreasonable amount of people, then I'll fix it ASAP before 1.20 is released as Preview.

@DHowett
Copy link
Member

DHowett commented Nov 16, 2023

I'd prefer to land this in main and then use the backport script to bring it in

@lhecker lhecker changed the base branch from release-1.19 to main November 21, 2023 16:44
@lhecker lhecker added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. labels Nov 21, 2023
@DHowett DHowett enabled auto-merge (squash) November 21, 2023 22:40
@lhecker lhecker added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 21, 2023
@DHowett
Copy link
Member

DHowett commented Nov 30, 2023

Error C2039: '_suppressLockChecks': is not a member of 'Microsoft::Terminal::Core::Terminal'

That's like a ChatGPT level hallucination 🤣

@lhecker
Copy link
Member Author

lhecker commented Dec 1, 2023

@DHowett The arm64 build got stuck because

Artifact logs-arm64-Release already exists for build 518974.

Do you mind if we force-merge this?

@DHowett DHowett disabled auto-merge December 4, 2023 20:28
@DHowett DHowett removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Dec 4, 2023
@DHowett DHowett disabled auto-merge December 4, 2023 20:29
@DHowett DHowett merged commit 204ebf3 into main Dec 4, 2023
16 of 18 checks passed
@DHowett DHowett deleted the dev/lhecker/atlasengine-default branch December 4, 2023 20:29
DHowett pushed a commit that referenced this pull request Dec 4, 2023
This enables AtlasEngine by default in the 1.19 release branch.
A future change will remove the alternative DxEngine entirely.

(cherry picked from commit 204ebf3)
Service-Card-Id: 91158876
Service-Version: 1.19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants