Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remaining 1.3 release features #119
Add remaining 1.3 release features #119
Changes from 19 commits
36a716a
43f0e73
73e8b4c
6d20ada
2d7de19
b6f061a
905ce8f
03e49a7
3dc0ada
128030e
0364da3
c474aa4
eafb007
022c61b
0eea38e
eac4314
d0da0dc
4c05d98
fda2bc1
1d75e22
486abea
d3c7454
67d5e0c
d43f817
7b9e37d
8a69f31
cf82dd6
b21b4cf
776b19f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I recommend rewriting this section from the ground up. How about a structure like this:
{ "command": "newTab" }
{ "command": { "action": "newTab", "commandline": "pwsh.exe" } }
"keys"
key to your json. It will look like this{ "command": "newTab", "keys": "ctrl+t" }
."name"
: to override the autogenerated name. Set to null to remove from the command palette."icon"
: to make the command stand out more in your command paletteThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: don't forget to probably update the key bindings page too. We have "keys" as required. So now it technically isn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't disagree with Carlos here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At no point do we explain where commands come from in the file.
We probably need to add a paragraph that covers something like:
and make sure we specifically show that the commands are getting added to
keybindings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great example of a command that does not have an autogenerated name. I'd create an example that looks cool, visually. Either open a few panes and send input to a few of them along they way. Or a simple one would be to just open the settings.json and the defaults.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd break this up into an example/section for profiles and another for scheme. My first question from reading this is "what properties can I access from a profile as opposed to a scheme?". It'd be nice if you provided a picture of the results that appear in the command palette from this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there supposed to be a gif here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's still on the issue checklist. I'll be creating gifs tonight.