Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renameTab to docs #76

Closed
wants to merge 1 commit into from

Conversation

ggadget6
Copy link

@ggadget6 ggadget6 commented Jun 24, 2020

Does what title says
closes #74
see microsoft/terminal#6557

@opbld32
Copy link

opbld32 commented Jun 24, 2020

Docs Build status updates of commit 69b02de:

🕙 Pending: waiting for processors (73 builds ahead of you)

⚠️ Docs Build is busy, currently there are 73 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

@opbld31
Copy link

opbld31 commented Jun 24, 2020

Docs Build status updates of commit 69b02de:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/customize-settings/key-bindings.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@@ -290,6 +290,27 @@ This opens a specific tab depending on the index.
| ---- | --------- | ------- | ----------- |
| `index` | Required | Integer | Tab that will open based on its position in the tab bar (starting at 0). |

### Rename the Tab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need to be badged with the Preview tag for Preview 1.2 (when it comes out). Not sure how we should track 1.2 things when 1.1 is actively in preview. @cinnamon-msft?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah. We should make a release-1.2 branch and have this PR point to there instead of master. Then, the Preview tag can be added and it will all go live once we merge the release-1.2 branch into the master and live branches.
My apologies for not creating this branch sooner!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, just made the release-1.2 branch 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay made the PR point to the new branch! Not sure what badging with the preview tag means though, is that something I'd have to do?

@ggadget6 ggadget6 changed the base branch from master to release-1.2 June 25, 2020 05:10
@cinnamon-msft
Copy link
Collaborator

Apologies for approving a later PR, but it looks like #90 covers this. Thanks for going through this process though, that's my bad that I merged a later PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document renameTab
5 participants