-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add renameTab to docs #76
Conversation
Docs Build status updates of commit 69b02de: 🕙 Pending: waiting for processors (73 builds ahead of you) |
Docs Build status updates of commit 69b02de: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
@@ -290,6 +290,27 @@ This opens a specific tab depending on the index. | |||
| ---- | --------- | ------- | ----------- | | |||
| `index` | Required | Integer | Tab that will open based on its position in the tab bar (starting at 0). | | |||
|
|||
### Rename the Tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may need to be badged with the Preview tag for Preview 1.2 (when it comes out). Not sure how we should track 1.2 things when 1.1 is actively in preview. @cinnamon-msft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah. We should make a release-1.2 branch and have this PR point to there instead of master. Then, the Preview tag can be added and it will all go live once we merge the release-1.2 branch into the master and live branches.
My apologies for not creating this branch sooner!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, just made the release-1.2 branch 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay made the PR point to the new branch! Not sure what badging with the preview tag means though, is that something I'd have to do?
Apologies for approving a later PR, but it looks like #90 covers this. Thanks for going through this process though, that's my bad that I merged a later PR. |
Does what title says
closes #74
see microsoft/terminal#6557