-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new-tab-same-directory.md to mention OSC 9;9 #779
Conversation
The docs mention using a specific escape sequence, but they don't mention the name. I've added a mention to OSC 9;9 as often shell themes / tools refer to the escape sequence by name. This gives users trying to enable this feature in their tools something to search for.
I'm open to better ways to mention the escape sequence name than in a parenthetical. I was trying to provide extra context in an unobtrusive way. |
Learn Build status updates of commit 6a6d79e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@zadjii-msft / @nguyen-dows -- Could you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @MattKotsenas, thanks for addition! Can you capitalize "osc to "OSC"?
Once that's fixed, then I can merge this PR in! :)
Fixed! Thanks for taking a look! |
Learn Build status updates of commit 7fa7bda: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I have merged the PR. Thanks @MattKotsenas! |
The docs mention using a specific escape sequence, but they don't mention the name.
I've added a mention to OSC 9;9 as often shell themes / tools refer to the escape sequence by name. This gives users trying to enable this feature in their tools something to search for.