Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update new-tab-same-directory.md to mention OSC 9;9 #779

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

MattKotsenas
Copy link
Contributor

The docs mention using a specific escape sequence, but they don't mention the name.

I've added a mention to OSC 9;9 as often shell themes / tools refer to the escape sequence by name. This gives users trying to enable this feature in their tools something to search for.

The docs mention using a specific escape sequence, but they don't mention the name.

I've added a mention to OSC 9;9 as often shell themes / tools refer to the escape sequence by name. This gives users trying to enable this feature in their tools something to search for.
@MattKotsenas
Copy link
Contributor Author

I'm open to better ways to mention the escape sequence name than in a parenthetical. I was trying to provide extra context in an unobtrusive way.

Copy link

Learn Build status updates of commit 6a6d79e:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/tutorials/new-tab-same-directory.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@mattwojo
Copy link
Collaborator

@zadjii-msft / @nguyen-dows -- Could you review?

Copy link
Collaborator

@nguyen-dows nguyen-dows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @MattKotsenas, thanks for addition! Can you capitalize "osc to "OSC"?
Once that's fixed, then I can merge this PR in! :)

@nguyen-dows nguyen-dows added the waiting-on-customer-reply We need more feedback from the author label Sep 20, 2024
@MattKotsenas
Copy link
Contributor Author

Hey @MattKotsenas, thanks for addition! Can you capitalize "osc to "OSC"? Once that's fixed, then I can merge this PR in! :)

Fixed!

Thanks for taking a look!

Copy link

Learn Build status updates of commit 7fa7bda:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/tutorials/new-tab-same-directory.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Collaborator

@nguyen-dows nguyen-dows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nguyen-dows nguyen-dows merged commit 315bc04 into MicrosoftDocs:main Sep 25, 2024
2 checks passed
@nguyen-dows
Copy link
Collaborator

I have merged the PR. Thanks @MattKotsenas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-customer-reply We need more feedback from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants