Update DesktopWindowXamlSource to describe how to avoid leaks #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRMerger7
added
the
do-not-merge
|
@ChrisGuzak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
PRMerger10
added
uwp/prod
|
thanks @ChrisGuzak! For future reference could you instead post draft PRs to https://github.com/microsoftdocs/windows-uwp-pr ? Tagging @ocalvo and @Austin-Lamb for comments on the content as well. |
asklar
approved these changes
Aug 9, 2021
windows.ui.xaml.hosting/windowsxamlmanager_initializeforcurrentthread_14911797.md
Outdated
Show resolved
Hide resolved
windows.ui.xaml.hosting/windowsxamlmanager_initializeforcurrentthread_14911797.md
Outdated
Show resolved
Hide resolved
windows.ui.xaml.hosting/windowsxamlmanager_initializeforcurrentthread_14911797.md
Show resolved
Hide resolved
sylveon
reviewed
Aug 9, 2021
windows.ui.xaml.hosting/windowsxamlmanager_initializeforcurrentthread_14911797.md
Show resolved
Hide resolved
…tthread_14911797.md Co-authored-by: Alexander Sklar <[email protected]>
|
@ChrisGuzak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
…tthread_14911797.md Co-authored-by: Alexander Sklar <[email protected]>
|
@ChrisGuzak : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Lucasty7
suggested changes
Mar 26, 2023
| m_xamlManager = nullptr; | ||
|
|
||
| // Drain the message queue after releasing WindowsXamlManager since rundown is async | ||
| while (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE)) |
There was a problem hiding this comment.
while (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE))
| // Drain the message queue after releasing WindowsXamlManager since rundown is async | ||
| while (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE)) | ||
| { | ||
| ::DispatchMessageW(&msg); |
| while (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE)) | ||
| { | ||
| ::DispatchMessageW(&msg); | ||
| } |
Lucasty7
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still need to check the details on this given the fixes that went into SV, but creating this to get early feedback.