Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and sln files #1

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Budtom
Copy link

@Budtom Budtom commented Sep 24, 2019

No description provided.

@TwoTenPvP
Copy link
Member

Some questions regarding this pullrequest. Why have you included UnityEditor.dll? It's not required.

Where did you get the UnityEngine.dll from? We are not allowed to willy nilly distribute the UnityEngine dll.

Why did you include Ruffles as binary? It should be resolved via Nuget (and it is). It does not need a binary file.

@Budtom
Copy link
Author

Budtom commented Sep 26, 2019

Why have you included UnityEditor.dll? It's not required.
The build threw an error at runtime without the reference to the dll, with an error message asking for it's reference.

Where did you get the UnityEngine.dll from? We are not allowed to willy nilly distribute the UnityEngine dll.
Sorry I did not realise that! I grabbed it from my local install

Why did you include Ruffles as binary? It should be resolved via Nuget (and it is). It does not need a binary file.
Again I got a runtime error without including it and to be honest no idea why I didn't realise it was from nuget. It doesn't get included into the release folder automatically hence the < CopyLocalLockFileAssemblies csproj line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants