feat: add guardian games slot (only to class item) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The option would fit in with the one for Festival of the Lost, fwiw. Or FOL could switch to this pattern. |
|
Thank you for bringing this up. I will move fotl to this pattern. |
|
Adds the Guardian Games slot only to the class item slot: NOT visible for other slots: |
TheYeshir13
approved these changes
May 7, 2023
| @@ -418,6 +418,10 @@ export class BungieApiService { | |||
|
|
|||
|
|
|||
| private getArmorPerk(v: DestinyInventoryItemDefinition): ArmorPerkOrSlot { | |||
| // Guardian Games | |||
| if (environment.featureFlags.enableGuardianGamesFeatures && ( v.hash === 1013401891 || v.hash === 366019830 || v.hash == 537041732) ) | |||
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically add a new category "GuardianGamesClassItem" and show it in the "class item" slot.
I can toggle it via an environment flag, so we can easily disable it (or remove it) when we do not need it anymore.
This felt nicer for the end user than adding an extra
advanced setting.for #134