Update activity list #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Control. Update reports to include new activities.
…on file properly.
Call bungie api to get profile information. Include display name and display name code to collector.
|
Howdy! I made a major refactor of the main.py, with more config options etc; Feel free to text me on Discord if you want to discuss changes quickly, otherwise Github is fine too - but my response time may not be as good as over there. |
…asses. Data storage relies on display name instead of platform/id. Makes it easier when running reports on multiple players. Logging shows character IDs, which are deleted, and the class of active characters. Cleaned up activities to more closely match API definitions. Class hashes are stored locally since they are not expected to change.
|
I'm sorry I don't know where the Discord is but yes, merge what you think fits. I've been kind of running rampant with changes in my branch and they spilled over here. I swear I saw a link somewhere but I don't know remember where. My name is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New activities added since 2022 include Iron Banner Zone Control and Iron Banner Rift. This will add to the activity definitions and include these activities in various generated reports.