Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with Julia 1.11 #37

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Fix compatibility with Julia 1.11 #37

merged 3 commits into from
Apr 11, 2024

Conversation

MilesCranmer
Copy link
Owner

  1. Needed to make REPL a dependency until [BUG] @cast does not work on Julia 1.11 comonicon/Comonicon.jl#272 is fixed.
  2. Also needed to import @main explicitly Base now exports @main comonicon/Comonicon.jl#257

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

Benchmark Results

master d4156b0... master/d4156b04717143...
main/random_sleep 0.531 ± 0.44 s 0.66 ± 0.14 s 0.804
time_to_load 1.77 ± 0.027 s 1.78 ± 0.049 s 0.996

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer merged commit e7cfcd1 into master Apr 11, 2024
6 checks passed
@MilesCranmer MilesCranmer deleted the fix-1-11 branch April 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MilesCranmer