Ajout de PHP 7.1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadoj-kuro
approved these changes
Apr 23, 2018
sadoj-kuro
approved these changes
Apr 23, 2018
|
Yep exact, en soi même plus besoin de restreindre la version, c’était pour des soucis de compatibilité avec ioncube. |
Eywek
requested changes
Apr 23, 2018
| @@ -75,7 +75,7 @@ | |||
| <td><?= affichImg($compatible['chmod']) ?></td> | |||
| </tr> | |||
| <tr> | |||
| <td>Version de PHP >= 5.6 < 7.1</td> | |||
| <td>Version de PHP >= 5.6 < 7.2</td> | |||
There was a problem hiding this comment.
On peut donc supprimer le "< 7.2"
| @@ -111,7 +111,7 @@ function affichImg($bool) { | |||
|
|
|||
| $compatible['curl'] = extension_loaded('cURL'); | |||
|
|
|||
| $compatible['phpVersion'] = version_compare(PHP_VERSION, '5.6', '>=') && version_compare(PHP_VERSION, '7.1', '<'); | |||
| $compatible['phpVersion'] = version_compare(PHP_VERSION, '5.6', '>=') && version_compare(PHP_VERSION, '7.2', '<'); | |||
There was a problem hiding this comment.
Même chose ici,
version_compare(PHP_VERSION, '5.6', '>=')devrait suffir.
There was a problem hiding this comment.
Cela mène sur la page d'installation de MineWeb.
Aussi, j'avais déjà testé avec PHP 7.2 et cela ne semble pas fonctionner.
There was a problem hiding this comment.
Il ne devrait pas y avoir de soucis avec ça normalement. Perso de mon compté pas de problèmes.
There was a problem hiding this comment.
Nop, désolé ! J'ai re-testé de A à Z
et même sur une autre infrastructure..
http://dev.maximemichaud.me/
Eywek
approved these changes
Apr 25, 2018
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 7.0 n'étant plus supporté depuis 4 mois. (Security Support ONLY)
Source : https://secure.php.net/supported-versions.php