-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache system for skin #9
Conversation
return base64_encode($content); | ||
}, 'skin'); | ||
|
||
if (empty($content)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour le coup, il vaudrait mieux récupérer le cache en premier, si il existe pas / est expiré fallback sur l'API de Mojang.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'engine' => $engine, | ||
'prefix' => $prefix, | ||
'path' => CACHE . 'skins' . DS, | ||
'duration' => $duration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Il faudrait donc ici mettre une durée pas trop longue, de quelques heures je pense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 heures actuellement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok parfait pour ça alors
No description provided.