-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append source set name for IntelliJ runs classpath module #351
Append source set name for IntelliJ runs classpath module #351
Conversation
Also make it optionally configurable if projects use a custom sourceset as main source set
@AbrarSyed Any chance to merge this? I've searched the whole file intensively, but there is no real easy way to detect the IntelliJ version without reading additional files (to check if a There will always be one version you will need to make manual changes with, but in my opinion it should be always the latest release you can use without making any additional changes. |
Good to know, I wasn't aware of this. Likely I'll talk to Lex and merge this in. |
Should be noted that this PR targets the |
Someone should move that stuff surround, make 2.2 master and go from there On July 6, 2016 9:54:21 AM CDT, kashike [email protected] wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
As it sits seince we have to keep each version seperate for old versions, I'm liking how each version just gets its own branch and 'master' is dead. |
I agree with that, but there should be some indication which is 'current', and so far that has been the one on master On July 6, 2016 2:57:06 PM CDT, LexManos [email protected] wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
Settings -> Branches -> Default Branch |
Oh they added that? Done. 2.2 |
Lol, I remember about asking for power to do that ages ago... On July 6, 2016 3:25:20 PM CDT, LexManos [email protected] wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
@kashike Changed target branch to FG_2.2 so this could be merged directly now. |
Is there a reason this is still not merged in? |
@thatsIch It appears that it might just happen not to get merged. |
I guess its been long enough that no one will be using a version of intellij where this wont work anymore.. |
@AbrarSyed As far I can see it still applies cleanly and I don't see any reason why it would be broken now. Should be fine to merge. |
@LexManos I approve, take a quick lookover plz |
With these changes ForgeGradle will automatically append the
main
source set name by default to the module name for the classpath. This is required for the run configurations to properly work in IntelliJ IDEA 2016.1 without additional manual changes.I've also made the special source set configurable, because some project may use a different source set at runtime than the main one. As an example, SpongeForge has an additional
java6
source set which is used to print a proper error to the user to upgrade Java, therefore at runtime thejava6
source set is required (which then depends on themain
source set). In that case, with this pull request it can be simply configured with:I'm still trying to come up with a way to support IntelliJ IDEA 15 at the same time but I haven't found anything simple yet to detect the version the currently created project is using. I'm open for suggestions.