Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Compat to 4, (keep existing compat) #94

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Compat package from 2.1, 3 to 2.1, 3, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #94 (eb2b481) into master (5f98d39) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head eb2b481 differs from pull request most recent head 052312a. Consider uploading reports for the commit 052312a to get more accurate results

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   19.29%   19.34%   +0.04%     
==========================================
  Files           7        7              
  Lines         456      429      -27     
==========================================
- Hits           88       83       -5     
+ Misses        368      346      -22     
Impacted Files Coverage Δ
src/Inputs/PWscf.jl 90.78% <0.00%> (-0.57%) ⬇️
src/Inputs/PHonon.jl 0.00% <0.00%> (ø)
src/Outputs/PWscf.jl 0.36% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f98d39...052312a. Read the comment docs.

@singularitti singularitti merged commit 07e82b5 into master May 30, 2022
@singularitti singularitti deleted the compathelper/new_version/2022-05-24-00-05-38-764-03371538769 branch May 30, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant