simplify Changer.java

Signed-off-by: Mineshafter61 <[email protected]>
Mineshafter61 · Jun 28, 2024 · 03d4dcf · 03d4dcf
1 parent 5c7e910
commit 03d4dcf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/main/java/mikeshafter/mikestcaddons/attachments/Changer.java b/src/main/java/mikeshafter/mikestcaddons/attachments/Changer.java
@@ -22,14 +22,15 @@ public Changer(MinecartMember<?> member, String name, Material type, int data) {
 	@Override
 	protected ConfigurationNode call(ConfigurationNode node) {
 		List<String> names = node.getList("names", String.class);
-		if (names.contains(this.name)) {
-			ItemStack item = node.get("item", ItemStack.class);
-			var meta = item.getItemMeta();
-			item.setType(this.type);
-			meta.setCustomModelData(this.data);
-			item.setItemMeta(meta);
-			node.set("item", item);
-		}
+		if (!names.contains(this.name)) return node;
+
+		ItemStack item = node.get("item", ItemStack.class);
+		var meta = item.getItemMeta();
+		item.setType(this.type);
+		meta.setCustomModelData(this.data);
+		item.setItemMeta(meta);
+		node.set("item", item);
+
 		return node;
 	}
 }
diff --git a/src/main/java/mikeshafter/mikestcaddons/attachments/SignActionAttachment.java b/src/main/java/mikeshafter/mikestcaddons/attachments/SignActionAttachment.java
@@ -33,7 +33,7 @@ public void execute(SignActionEvent info) {
 
 			for (MinecartMember<?> member : info.getMembers()) {
 				Changer a = new Changer(member, name, material, customModelData);
-				new Thread(a).start();
+				a.run();
 			}
 		}
 	}