refs #54 nginx-proxy caching #55
Conversation
* proof-of-concept (WIP) using internal nginx proxy caching instead of relying on thumbor's result storage and try_files
* the new nginx-proxy-cache will replace nginx-proxy with built-in proxy caching by nginx instead of mapping to thumbor's data folder * refreshed nginx.tmpl from upstream (jwilder/nginx-proxy) * updated template to add thumbor + proxy caching with minimal control using environment variables (for further customization, users can supply a proxy.conf file) * updated tests: added proxy caching tests + removed some tests that are unnecessary or difficult to do with the built-in proxy caching (for example, overriding the cached data is somehow detected by nginx) * updated recipes to reflect the new setup (no need for result storage caching in thumbor, and no data volume) * TODO: revert changes to nginx-proxy and add deprecation warning
| add_header 'Access-Control-Allow-Origin' '{{ or .CorsOrigin "*" }}'; | ||
| add_header 'Access-Control-Allow-Credentials' 'true'; | ||
| add_header 'Access-Control-Allow-Methods' 'GET, POST, PUT, DELETE, OPTIONS'; | ||
| add_header 'Access-Control-Allow-Headers' 'Accept,Authorization,Cache-Control,Content-Type,DNT,If-Modified-Since,Keep-Alive,Origin,User-Agent,X-Mx-ReqToken,X-Requested-With'; |
There was a problem hiding this comment.
X-Mx-ReqToken what this header is for? Quick search pointed to some java lib/app. Is it sent by browsers?
There was a problem hiding this comment.
Good question :) this was lifted from https://github.com/APSL/docker-thumbor/blob/a1bf9bd1bf9520f02fa57ba1a7cd66778edc3f4b/nginx/nginx.conf#L64 originally ... I didn't really look into it at the time and just continued to pass it over... Is it worth refining this?
nginx-proxy-cache/nginx.tmpl
Outdated
|
|
||
| {{ define "thumbor-caching" }} | ||
| {{ $proxyCacheSize := or .ProxyCacheSize "100m" }} | ||
| {{ $proxyCacheInactive := or .ProxyCacheInactive "300m" }} |
There was a problem hiding this comment.
I think default sizes/times are too small.
There was a problem hiding this comment.
Thanks. I was wondering what's a reasonable default. This is already larger than the nginx defaults, but wasn't sure how far I should go... What would you recommend?
There was a problem hiding this comment.
I updated these values, and also realized I was a bit confused between the memory size used for caching and the (on-disk) max cache size, so added a separate ENV as well.
* added README for nginx-proxy-cache * updated recipes to add a persisted cache folder
…k) and memory size
caching by nginx instead of mapping to thumbor's data folder
using environment variables (for further customization, users can
supply a proxy.conf file)
unnecessary or difficult to do with the built-in proxy caching
(for example, overriding the cached data is somehow detected by nginx)
caching in thumbor, and no data volume)