Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide admin menu items before authorizing with Salesforce. Thanks to WordPress user mgparisi for pointing this out. #326

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Hide admin menu items before authorizing with Salesforce. Thanks to WordPress user mgparisi for pointing this out. #326

merged 2 commits into from
Oct 28, 2019

Conversation

jonathanstegall
Copy link
Member

@jonathanstegall jonathanstegall commented Oct 28, 2019 •
edited
Loading

What does this PR do?

This closes #325. It hides all menu items except Settings and Authorize if the user has not authorized with Salesforce.

Here's how the menu visibility works:

  1. If user has not filled in the credentials, only show Settings.
  2. If user has filled in credentials but has not authorized the app in Salesforce, only show Settings and Authorize.
  3. If they've actually authorized with Salesforce, show all the available items.

How do I test this PR?

  • install the plugin
  • fill in the credentials but don't authorize
  • authorize

@jonathanstegall jonathanstegall self-assigned this Oct 28, 2019
@jonathanstegall jonathanstegall added the feature Pull request that adds a feature label Oct 28, 2019
@jonathanstegall jonathanstegall added this to the v1.8.x milestone Oct 28, 2019
@jonathanstegall jonathanstegall merged commit 0e30692 into master Oct 28, 2019
@jonathanstegall jonathanstegall deleted the 325-hide-menu-items-before-authorizing branch October 28, 2019 20:42
@jonathanstegall jonathanstegall changed the title Hide admin menu items before authorizing with Salesforce Hide admin menu items before authorizing with Salesforce. Thanks to WordPress user mgparisi for pointing this out. Oct 28, 2019
@jonathanstegall jonathanstegall mentioned this pull request Dec 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonathanstegall jonathanstegall

Labels
feature Pull request that adds a feature
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

Users can see fieldmap/log/etc tabs before they've authorized with Salesforce
1 participant
@jonathanstegall