Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a Salesforce query has invalid fields, clear it from the plugin's storage. Thanks to WordPress users @nishithmistry, @zumajoe, @alexeympw, and @jesodoth. #345

Merged
merged 5 commits into from
Mar 19, 2020
Merged

When a Salesforce query has invalid fields, clear it from the plugin's storage. Thanks to WordPress users @nishithmistry, @zumajoe, @alexeympw, and @jesodoth. #345

merged 5 commits into from
Mar 19, 2020

Conversation

jonathanstegall
Copy link
Member

What does this PR do?

This fixes #344 by:

  1. Checking for an INVALID_FIELD response from the Salesforce API. If it gets one, it will clear the saved query and make a specific error log.
  2. If a user saves their fieldmap, it will also clear the saved query, in the assumption that the fields being mapped may have changed.

How do I test this PR?

  • create a working fieldmap
  • delete a field in Salesforce
  • see that the current running query is cleared the next time it runs
  • save the fieldmap settings in the admin
  • see that the current running query is cleared immediately

@jonathanstegall jonathanstegall changed the title 343 deleting fields fix When a Salesforce query has invalid fields, clear it from the storage Mar 19, 2020
@jonathanstegall jonathanstegall self-assigned this Mar 19, 2020
@jonathanstegall jonathanstegall added the bug fix Pull request that fixes a bug label Mar 19, 2020
@jonathanstegall jonathanstegall added this to the v1.9.0 milestone Mar 19, 2020
@jonathanstegall jonathanstegall changed the title When a Salesforce query has invalid fields, clear it from the storage When a Salesforce query has invalid fields, clear it from the plugin's storage. Mar 19, 2020
@jonathanstegall jonathanstegall merged commit a201ed3 into master Mar 19, 2020
@jonathanstegall jonathanstegall deleted the 343-deleting-fields-fix branch March 19, 2020 22:30
@jonathanstegall jonathanstegall changed the title When a Salesforce query has invalid fields, clear it from the plugin's storage. When a Salesforce query has invalid fields, clear it from the plugin's storage. Thanks to WordPress users @nishithmistry, @zumajoe, @alexeympw, and @jesodoth. Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonathanstegall jonathanstegall

Labels
bug fix Pull request that fixes a bug
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.

The currently_pulling_query option can cause broken SOQL queries
1 participant
@jonathanstegall