Fix tracer file type which should be used to decide the output format.

[rockindy]

No description provided.

[eyck]

That's a bit difficult as the tracer only take the stem of the file name. This is because the tracer generates 2 files in the standard configurtion: one for signals and one for transactions. Any ideas on how to handle this?

[eyck]

But this is exactly what ' tracer(std::string const&& name, file_type tx_type, file_type sig_type, sc_core::sc_object* top = nullptr)' is doing: you provide a name for the trace files and a type for the transaction trace (tx_type) and for the type of the signal trace (sig_type). Moreover you can change these setting alter on by setting the cci parameter tx_trace_type and sig_trace_type. How is this different from what you propose? Best

…

-Eyck Am 07.08.2024 um 07:32 schrieb rockindy:

How about to add two functions to set |tx_type| and |sig_type|? In the constructor of |tracer|, we can set default values for |tx_type| and |sig_type|(e.g., |TEXT| and |FST|). If users want to change the output format, they can use additional functions. For example: tracer(std::stringconst&& name,bool enable_tx,bool enable_sig, sc_core::sc_object* top, sc_core::sc_module_nameconst& nm); set_tx_type(file_type tx_type); set_sig_type(file_type sig_type); — Reply to this email directly, view it on GitHub <#55 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADKYF3GBH6YHSAHFLFP6V3ZQGWONAVCNFSM6AAAAABMDQA32WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZSGY2TCMZUHA>. You are receiving this because you commented.Message ID: ***@***.***>

[eyck]

As far as I can see the current implementation in main & develop allow to select the output formats for signal tracing and transaction tracing independently. Therefore there need to be 2 of the file_type parameters.

[eyck]

This logic is wrong as it effectively skips the signal trace type. This way it falls pacl to vcd if selected any of the tx trace type or it falls back to text type transaction trace if any of the signal trace types is selected.

[rockindy]

Sorry, the first commit was my fault.
My original purpose is try to use configurable_tracer to output a vcd file.
So the correct way is to add a new constructor for configurable_tracer to pass tx_type and sig_type to tracer.

Please check my following commits, thank you.

Usage example:

    scc::configurable_tracer trace("axi4_tlm_pin_tlm",
                                   scc::tracer::file_type::FST,  // type of trace file for transactions
                                   scc::tracer::file_type::SC_VCD,  // type of trace file for signals
                                   true); // all units by default traced