Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Proposal] Export DEFAULT_TEQUILA_MIRROR_OPTIONS like mirrorcli #8

Merged
merged 2 commits into from
May 18, 2021

Conversation

0xslipk
Copy link
Contributor

@0xslipk 0xslipk commented May 14, 2021

Hi guys,

This PR export from Mirror Client the DEFAULT_TEQUILA_MIRROR_OPTIONS like mirrorcli does.

@0xslipk
Copy link
Contributor Author

0xslipk commented May 14, 2021

@hanjukim please take a look when you get a chance 😄

@hanjukim
Copy link
Contributor

@simcheolhwan could you confirm that addresses are correct?

@simcheolhwan
Copy link
Contributor

@simcheolhwan could you confirm that addresses are correct?

The assets are correct.
But mSPY, mCOIN is not included.

@jarcodallo Would you include them and make a new commit into this branch?

@0xslipk
Copy link
Contributor Author

0xslipk commented May 14, 2021

@simcheolhwan could you confirm that addresses are correct?

The assets are correct.

But mSPY, mCOIN is not included.

@jarcodallo Would you include them and make a new commit into this branch?

Yes sure. I will do it

@0xslipk
Copy link
Contributor Author

0xslipk commented May 16, 2021

@simcheolhwan I added the mAssets to tequila and columbus options.

@simcheolhwan
Copy link
Contributor

Yes they are correct

@0xslipk
Copy link
Contributor Author

0xslipk commented May 17, 2021

@hanjukim ready to merge 🚀

@hanjukim hanjukim self-requested a review May 18, 2021 05:04
@hanjukim hanjukim merged commit 44c0ab6 into Mirror-Protocol:main May 18, 2021
@0xslipk 0xslipk deleted the add-tequila-contracts branch May 18, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants