enhance(SSO): Attributeの調整 (#555)

MisskeyIO · Mar 20, 2024 · eb88472 · eb88472
1 parent 478c1eb
commit eb88472
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/packages/backend/src/server/sso/JWTIdentifyProviderService.ts b/packages/backend/src/server/sso/JWTIdentifyProviderService.ts
@@ -172,7 +172,9 @@ export class JWTIdentifyProviderService {
 			const roles = await this.roleService.getUserRoles(user.id);
 
 			const payload: JWTPayload = {
-				name: user.name ?? user.username,
+				name: user.name ? `${user.name} (@${user.username})` : `@${user.username}`,
+				given_name: user.name ?? undefined,
+				family_name: `@${user.username}`,
 				preferred_username: user.username,
 				profile: `${this.config.url}/@${user.username}`,
 				picture: user.avatarUrl ?? undefined,

diff --git a/packages/backend/src/server/sso/SAMLIdentifyProviderService.ts b/packages/backend/src/server/sso/SAMLIdentifyProviderService.ts
@@ -492,20 +492,28 @@ export class SAMLIdentifyProviderService {
 													'#text': user.id,
 												},
 											},
+											...(user.name ? [{
+												'@Name': 'firstName',
+												'@NameFormat': 'urn:oasis:names:tc:SAML:2.0:attrname-format:basic',
+												'saml:AttributeValue': {
+													'@xsi:type': 'xs:string',
+													'#text': user.name,
+												},
+											}] : []),
 											{
-												'@Name': 'displayname',
+												'@Name': 'lastName',
 												'@NameFormat': 'urn:oasis:names:tc:SAML:2.0:attrname-format:basic',
 												'saml:AttributeValue': {
 													'@xsi:type': 'xs:string',
-													'#text': user.name ?? user.username,
+													'#text': `@${user.username}`,
 												},
 											},
 											{
-												'@Name': 'name',
+												'@Name': 'displayName',
 												'@NameFormat': 'urn:oasis:names:tc:SAML:2.0:attrname-format:basic',
 												'saml:AttributeValue': {
 													'@xsi:type': 'xs:string',
-													'#text': user.username,
+													'#text': user.name ? `${user.name} (@${user.username})` : `@${user.username}`,
 												},
 											},
 											{