Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

userannouncement v2 #106

Merged
merged 9 commits into from
Jul 23, 2023
Merged

userannouncement v2 #106

merged 9 commits into from
Jul 23, 2023

Conversation

CyberRex0
Copy link

ユーザー向けお知らせ機能の改善
・ダイアログを閉じることができるようになるまでの待機時間を設定できるように
・お知らせの内容を直接表示するように変更

riku6460
riku6460 reviewed Jul 23, 2023
View reviewed changes
Copy link
Collaborator

@riku6460 riku6460 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

流し見した感じよさそう

前回の PR 分まだ使ってないので、マイグレを前回のやつと混ぜても良いかもしれない？

@CyberRex0
Copy link
Author

確かに　ということで1つにしてみた

riku6460
riku6460 reviewed Jul 23, 2023
View reviewed changes
Copy link
Collaborator

@riku6460 riku6460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前回の PR で指摘漏れてたけど、userId にインデックス張らないとまずいかも

@CyberRex0
Copy link
Author

インデックスの張り方が謎

@riku6460
Copy link
Collaborator

多分この状態でマイグレ生成するといい感じかも？

@riku6460 riku6460 merged commit 08b49a6 into MisskeyIO:user-announcement Jul 23, 2023
14 checks passed
@riku6460 riku6460 mentioned this pull request Jul 23, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u1-liquid u1-liquid u1-liquid approved these changes

@riku6460 riku6460 riku6460 approved these changes

Assignees
No one assigned
Labels
packages/backend packages/frontend packages/misskey-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CyberRex0 @riku6460 @u1-liquid