Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): Change isPublic to correctly recognize as:Public term #108

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fix(backend): Change isPublic to correctly recognize as:Public term #108

merged 1 commit into from
Jul 24, 2023

Conversation

u1-liquid
Copy link
Member

What

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

riku6460
riku6460 reviewed Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@riku6460 riku6460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG のコミットはいらないかも

@u1-liquid u1-liquid force-pushed the misskey-dev/#11347/fix-aspublic branch from 1ea02cd to bbf987b Compare July 24, 2023 17:13
@u1-liquid u1-liquid changed the title Misskey dev/#11347/fix aspublic fix(backend): Change isPublic to correctly recognize as:Public term Jul 24, 2023
@riku6460 riku6460 merged commit 4a2bb60 into MisskeyIO:io Jul 24, 2023
14 checks passed
@u1-liquid u1-liquid deleted the misskey-dev/#11347/fix-aspublic branch July 24, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riku6460 riku6460 riku6460 approved these changes

Assignees
No one assigned
Labels
packages/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@u1-liquid @riku6460 @hakatashi